WIP: Ensure rectilinear rasters support geometry selections #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
commented
Sep 1, 2022
| if keep_index: | ||
| da = dataset.data[dataset.vdims[0].name].copy().rename(dim.name) | ||
| da.data[:] = data | ||
| return da |
There was a problem hiding this comment.
Need to find a better solution here. This basically ensures that keep_index + expanded returns a 2D coordinate DataArray even for a rectilinear (i.e. 1D coordinate) array. This implementation does not handle:
- packed vdims
- dask backed value arrays
philippjfr
commented
Sep 1, 2022
| @@ -73,7 +73,7 @@ def spatial_select_gridded(xvals, yvals, geometry): | |||
| target = Image((xs, ys, np.empty(ys.shape+xs.shape))) | |||
| poly = Polygons([geometry]) | |||
| mask = rasterize(poly, target=target, dynamic=False, aggregator='any') | |||
| return mask.dimension_values(2, flat=False) | |||
| return mask.interface.values(mask, mask.vdims[0], keep_index=True) | |||
| else: | |||
| mask = spatial_select_columnar(xvals.flatten(), yvals.flatten(), geometry) | |||
| return mask.reshape(xvals.shape) | |||
There was a problem hiding this comment.
This branch should also ensure that the mask that is returned is still an xarray object if the input is an xarray object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat hacky fix to ensure that:
Imagecorrectly implements dim expression selections