Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use colorcet register_cmap #5460

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Use colorcet register_cmap #5460

merged 1 commit into from
Oct 4, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 28, 2022

When holoviz/colorcet#90 is merged and released, it will remove the DeprecationWarning.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #5460 (7e8c66b) into master (07ef9b3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5460      +/-   ##
==========================================
+ Coverage   88.09%   88.12%   +0.03%     
==========================================
  Files         301      301              
  Lines       61991    62096     +105     
==========================================
+ Hits        54608    54722     +114     
+ Misses       7383     7374       -9     
Impacted Files Coverage Δ
holoviews/plotting/mpl/__init__.py 81.61% <100.00%> (-0.14%) ⬇️
holoviews/core/options.py 82.44% <0.00%> (-0.36%) ⬇️
holoviews/__init__.py 72.22% <0.00%> (ø)
holoviews/core/data/pandas.py 93.30% <0.00%> (ø)
holoviews/tests/core/test_apply.py 100.00% <0.00%> (ø)
holoviews/tests/plotting/bokeh/test_sankey.py 100.00% <0.00%> (ø)
...iews/tests/plotting/matplotlib/test_elementplot.py 100.00% <0.00%> (ø)
holoviews/plotting/bokeh/element.py 88.87% <0.00%> (+0.01%) ⬆️
holoviews/core/util.py 86.08% <0.00%> (+0.02%) ⬆️
...loviews/tests/plotting/matplotlib/test_renderer.py 98.70% <0.00%> (+0.02%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

Either need to have a fallback or need to pin the new version of colorcet.

@hoxbro
Copy link
Member Author

hoxbro commented Oct 3, 2022

The register_cmap function has been in colorcet as a "normal" matplotlib import for a long time, and the updated register_cmap function added in holoviz/colorcet#90 should be backward compatible. So I don't think a pin is necessary, but correct me if I'm wrong.

@philippjfr
Copy link
Member

Ah did not know it was already there before the version. Ignore me then.

@jlstevens
Copy link
Contributor

Colorcet has now been released with that PR merged there. Merging here too, thanks!

@jlstevens jlstevens merged commit 4b6aacf into master Oct 4, 2022
@jlstevens jlstevens deleted the fix_register_colormap branch October 4, 2022 09:02
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants