Support jupyterlite #5502
Merged
Support jupyterlite #5502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5502 +/- ##
==========================================
- Coverage 88.09% 88.08% -0.01%
==========================================
Files 302 302
Lines 62269 62275 +6
==========================================
Hits 54858 54858
- Misses 7411 7417 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jlstevens
reviewed
Nov 1, 2022
|
Other than one or two minor comments, looks good to merge! (Ignoring the issue with CI for macos of course!) |
jlstevens
reviewed
Nov 1, 2022
|
I'm going to rebase now CI tests are passing on macos so that this can be the last code PR in the release... |
|
Will merge once the tests are green! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5475
The solution to the problem is to use the existing
notebook_extensionand not thepyodide_extensioninside the jupyterlite:Therefore a small check is added to see if holoviews is inside jupyterlite, and depending on that, either use
notebook_extensionorpyodide_extension.