-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance of the code #5509
Maintenance of the code #5509
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5509 +/- ##
==========================================
+ Coverage 88.13% 88.22% +0.09%
==========================================
Files 302 302
Lines 62357 62180 -177
==========================================
- Hits 54959 54860 -99
+ Misses 7398 7320 -78
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The reason for this is the pin on panel has pinned bokeh to be minimum 2.4
Yes please remove, it no longer exists. Since we now require Python >= 3.7 we could also consider swapping OrderedDict for regular dicts but that can be a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that DFrame
import was already removed so this looks good to me. Really appreciate this, thanks!
This PR has done a couple of things to update the code:
except:
in bcd6cda.except Exception:
orexcept ImportError
.MercatorTileSource
,cartesian_to_axial
,built_in_themes
was in Bokeh 1.4.0I noticed that file
...interface
does not exist, so I think the following lines should be updated or removed if no longer needed.holoviews/holoviews/plotting/bokeh/__init__.py
Lines 19 to 22 in e5224c6