Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance of the code #5509

Merged
merged 28 commits into from
Dec 27, 2022
Merged

Maintenance of the code #5509

merged 28 commits into from
Dec 27, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 7, 2022

This PR has done a couple of things to update the code:

  1. Convert (most) of the format strings to f-strings.
  2. Remove bare except: in bcd6cda.
    • This is either done with except Exception: or except ImportError.
  3. Remove checks if pandas are installed in c4a94a2, as it is a required dependency.
  4. Remove Python 2 code in 6dc7315 and 74201a9
  5. Cleanup bokeh imports in 223eea1.
    • MercatorTileSource, cartesian_to_axial, built_in_themes was in Bokeh 1.4.0

I noticed that file ...interface does not exist, so I think the following lines should be updated or removed if no longer needed.

try:
from ...interface import DFrame
except:
DFrame = None

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Merging #5509 (3fb9eba) into master (7d18655) will increase coverage by 0.09%.
The diff coverage is 63.35%.

@@            Coverage Diff             @@
##           master    #5509      +/-   ##
==========================================
+ Coverage   88.13%   88.22%   +0.09%     
==========================================
  Files         302      302              
  Lines       62357    62180     -177     
==========================================
- Hits        54959    54860      -99     
+ Misses       7398     7320      -78     
Impacted Files Coverage Δ
holoviews/__init__.py 67.85% <0.00%> (ø)
holoviews/core/data/dask.py 90.00% <ø> (-0.18%) ⬇️
holoviews/core/data/multipath.py 86.55% <0.00%> (ø)
holoviews/core/data/util.py 58.92% <0.00%> (ø)
holoviews/core/decollate.py 95.93% <0.00%> (ø)
holoviews/core/traversal.py 62.50% <ø> (-1.64%) ⬇️
holoviews/element/annotation.py 87.28% <0.00%> (ø)
holoviews/element/path.py 86.87% <0.00%> (ø)
holoviews/element/sankey.py 95.04% <0.00%> (ø)
holoviews/element/stats.py 85.54% <0.00%> (ø)
... and 164 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

I noticed that file ...interface does not exist, so I think the following lines should be updated or removed if no longer needed.

Yes please remove, it no longer exists. Since we now require Python >= 3.7 we could also consider swapping OrderedDict for regular dicts but that can be a separate PR.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that DFrame import was already removed so this looks good to me. Really appreciate this, thanks!

@philippjfr philippjfr merged commit 8e85937 into master Dec 27, 2022
@philippjfr philippjfr deleted the maintenance branch December 27, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants