Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the top __init__ module #5516

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Cleanup the top __init__ module #5516

merged 3 commits into from
Nov 23, 2022

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Nov 22, 2022

  • Remove unused numpy import
  • No longer import io to use io.open and instead use the builtin open as these two are the same in Python 3.

@maximlt maximlt requested a review from hoxbro November 22, 2022 12:53
@maximlt maximlt added this to the 1.15.3 milestone Nov 22, 2022
holoviews/__init__.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #5516 (f1b0fdf) into master (e5224c6) will decrease coverage by 0.17%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #5516      +/-   ##
==========================================
- Coverage   88.08%   87.91%   -0.18%     
==========================================
  Files         302      302              
  Lines       62277    61607     -670     
==========================================
- Hits        54859    54163     -696     
- Misses       7418     7444      +26     
Impacted Files Coverage Δ
holoviews/__init__.py 67.85% <66.66%> (-0.57%) ⬇️
holoviews/core/data/cudf.py 16.31% <0.00%> (-3.69%) ⬇️
holoviews/core/data/spatialpandas_dask.py 79.24% <0.00%> (-3.30%) ⬇️
holoviews/ipython/magics.py 62.60% <0.00%> (-2.15%) ⬇️
holoviews/core/data/ibis.py 77.37% <0.00%> (-2.09%) ⬇️
holoviews/ipython/display_hooks.py 58.63% <0.00%> (-1.67%) ⬇️
holoviews/element/tabular.py 49.18% <0.00%> (-1.62%) ⬇️
...iews/tests/plotting/matplotlib/test_elementplot.py 98.46% <0.00%> (-1.54%) ⬇️
holoviews/core/overlay.py 66.42% <0.00%> (-1.38%) ⬇️
holoviews/plotting/util.py 69.26% <0.00%> (-1.38%) ⬇️
... and 84 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maximlt
Copy link
Member Author

maximlt commented Nov 23, 2022

CI failing for unrelated problems, merging.

@maximlt maximlt merged commit 5d22218 into master Nov 23, 2022
@maximlt maximlt deleted the cleanup_top_init branch November 23, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants