Fix the ibis histogram #5531
Draft
Fix the ibis histogram #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x/ibis-duckdb-no-rowid
Codecov Report
@@ Coverage Diff @@
## master #5531 +/- ##
==========================================
- Coverage 88.12% 87.55% -0.58%
==========================================
Files 302 302
Lines 62284 62348 +64
==========================================
- Hits 54890 54589 -301
- Misses 7394 7759 +365
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippjfr
reviewed
Dec 3, 2022
| assert IbisInterface._get_backend(data) | ||
|
|
||
| def test_index_ibis_table(data): | ||
| table = IbisInterface._index_ibis_table(data) |
philippjfr
reviewed
Dec 3, 2022
| xaxis, yaxis = plot_bokeh.axis | ||
| # Then | ||
| assert isinstance(xaxis, xaxis_type) | ||
| assert isinstance(yaxis, yaxis_type) |
There was a problem hiding this comment.
Let's remove this one for now.
|
Adding docstrings with signatures to Interface and GridInterface would definitely a very worthwhile first step towards better defining documenting the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables plotting histograms with the ibis backend.
Depends on #5527
For context check out