Check for categorical data to histogram #5540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5540 +/- ##
=======================================
Coverage 88.22% 88.22%
=======================================
Files 302 302
Lines 62179 62187 +8
=======================================
+ Hits 54857 54865 +8
Misses 7322 7322
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The tests fails on Python 3.11 only and I believe its not related to this PR. This should be ready for review. |
|
@MarcSkovMadsen Change makes good sense to me. Hopefully the tests will now pass (including 3.11) after the merge commit at which point I am happy to see this merge. |
|
Looks like all tests are now green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses hvplot/#998 by providing an error message if the user tries to create a
histogramfrom categorical data.Before the user would get the error message
numpy.core._exceptions._UFuncNoLoopError: ufunc 'multiply' did not contain a loop with signature matching types (dtype('<U1'), dtype('float64')) -> NoneThis is not an error message that a new user to python and plotting would be able to make sense of. It takes a long time to realize that theoretically a histogram is for numerical data only. For example users can find plotly express examples of creating "histograms" from categorical data. In their documentation its the second example you see. I think they realized this is a very common use case.