Ensure dynamically created subplots can be updated #5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5555 +/- ##
=======================================
Coverage 88.12% 88.13%
=======================================
Files 302 302
Lines 62284 62304 +20
=======================================
+ Hits 54890 54910 +20
Misses 7394 7394
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks for the fix! As you say this was resulting in very confusing behavior which my explain why I've always reached for Will merge when the tests pass for inclusion in the immediate follow up release. |
|
Tests passed. Merging now as this is an important fix. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a very bad bug that definitely should have been caught.
Fixes #5168