Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plotly legendgroup unique #5570

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Make plotly legendgroup unique #5570

merged 1 commit into from
Dec 30, 2022

Conversation

jj-github-jj
Copy link
Contributor

@jj-github-jj jj-github-jj commented Dec 18, 2022

Fixes #5560

made plotly legendgroup unique to fix single trace enable disable instead of all traces

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Merging #5570 (e2c934c) into main (c21b981) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5570      +/-   ##
==========================================
- Coverage   88.13%   88.13%   -0.01%     
==========================================
  Files         302      302              
  Lines       62304    62304              
==========================================
- Hits        54911    54910       -1     
- Misses       7393     7394       +1     
Impacted Files Coverage Δ
holoviews/plotting/plotly/element.py 85.14% <ø> (ø)
holoviews/operation/datashader.py 83.89% <0.00%> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jj-github-jj
Copy link
Contributor Author

Not sure why this single line change is failing only on ubuntu 3.9 only and passing on all other versions. I dont have ubuntu to see what is failing. This is my first pull request with only a single line of code change that is working as expected on my windows machine..Please help.

@hoxbro
Copy link
Member

hoxbro commented Dec 30, 2022

It is a flaky test.

Can you test if legendgroup is needed at all?

@hoxbro hoxbro changed the title made plotly legendgroup unique to fix single trace enable disable ins… Make plotly legendgroup unique Dec 30, 2022
@jj-github-jj
Copy link
Contributor Author

It is a flaky test.

Can you test if legendgroup is needed at all?

Not sure what you mean by if legendgroup is needed at all? It has some functionality in plotly such as enabling/disabling a number of traces together that share a common legendgroup.

@hoxbro
Copy link
Member

hoxbro commented Dec 30, 2022

Nevermind. I will merge it as is.

Thank you for the PR 🥇

@hoxbro hoxbro merged commit 1077a7c into holoviz:main Dec 30, 2022
@jj-github-jj jj-github-jj deleted the plotly-make-legend-group-unique-fixes-trace-enable-disable-via-cliking branch December 30, 2022 23:09
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on legend for traces to enable/disable does not work with plotly back end. It does work on Bokeh
3 participants