Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling for plotting class lookups on empty Dynamic/HoloMap #5604

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

philippjfr
Copy link
Member

Supersedes #5603

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Merging #5604 (6be2bc3) into main (387503f) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #5604      +/-   ##
==========================================
- Coverage   88.33%   88.33%   -0.01%     
==========================================
  Files         302      302              
  Lines       62428    62430       +2     
==========================================
+ Hits        55147    55148       +1     
- Misses       7281     7282       +1     
Impacted Files Coverage Δ
holoviews/plotting/renderer.py 71.54% <66.66%> (-0.13%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jlstevens
Copy link
Contributor

Thanks!

Took me a while to realize that the issue was simply in formatting a message for the SkipRendering exception!

@jlstevens
Copy link
Contributor

Ah, thought I had merged this already. Anyway, tests are green and I've checked this fix works.

@jlstevens jlstevens merged commit a441bfa into main Feb 1, 2023
@jlstevens jlstevens deleted the handle_empty_maps branch February 1, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants