Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple option to tox.ini to fix PyPi build #5612

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Add simple option to tox.ini to fix PyPi build #5612

merged 2 commits into from
Feb 7, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Feb 6, 2023

The Pypi build is failing because flakes has been removed. This adds a simple option that only installs holoviews with no optional dependencies.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

Merging #5612 (f50bdc5) into main (bfd7142) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5612      +/-   ##
==========================================
- Coverage   88.28%   88.27%   -0.02%     
==========================================
  Files         302      302              
  Lines       62478    62495      +17     
==========================================
+ Hits        55161    55168       +7     
- Misses       7317     7327      +10     
Impacted Files Coverage Δ
holoviews/plotting/bokeh/element.py 88.17% <0.00%> (-0.44%) ⬇️
holoviews/operation/datashader.py 83.90% <0.00%> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[skip ci]
@hoxbro
Copy link
Member Author

hoxbro commented Feb 7, 2023

This fixes the PyPi build, see: https://github.com/holoviz/holoviews/actions/runs/4111435632

@hoxbro hoxbro merged commit 349d80a into main Feb 7, 2023
@hoxbro hoxbro deleted the pypi_fix branch February 7, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants