Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active_tools to only be set for enabled tools #5616

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Feb 8, 2023

Fixes #5614

This PR makes it so that the default activate_tools is only used if the tools are enabled. It also handles an edge case where a wrong-spelled active_tools will give a KeyError.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Merging #5616 (24e92af) into main (bfd7142) will decrease coverage by 0.02%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main    #5616      +/-   ##
==========================================
- Coverage   88.28%   88.27%   -0.02%     
==========================================
  Files         302      302              
  Lines       62478    62501      +23     
==========================================
+ Hits        55161    55174      +13     
- Misses       7317     7327      +10     
Impacted Files Coverage Δ
holoviews/plotting/bokeh/element.py 88.20% <88.88%> (-0.41%) ⬇️
holoviews/tests/core/test_dynamic.py 99.45% <100.00%> (ø)
holoviews/tests/plotting/bokeh/test_callbacks.py 98.65% <100.00%> (ø)
holoviews/tests/plotting/bokeh/test_server.py 100.00% <100.00%> (ø)
holoviews/operation/datashader.py 83.90% <0.00%> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit 8bc04d0 into main Feb 9, 2023
@hoxbro hoxbro deleted the fix_active_tool branch February 9, 2023 14:47
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New and Unexpected Warning: Tool of type could not be found and could not be activated by default.
2 participants