Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use CustomJS for linked axes in Bokeh 2.4 #5620

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Feb 10, 2023

Resolves #5602

The problem is fixed in the latest Bokeh dev release. This makes a simple if-statement enabling the previous fix only for Bokeh 2.4.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #5620 (77c69e6) into main (8bc04d0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5620   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files         302      302           
  Lines       62501    62502    +1     
=======================================
+ Hits        55174    55175    +1     
  Misses       7327     7327           
Impacted Files Coverage Δ
holoviews/plotting/bokeh/callbacks.py 63.19% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro changed the title Add if statement to linked_axes for Bokeh 3 Only use CustomJS for linked axes in Bokeh 2.4 Feb 10, 2023
@hoxbro hoxbro merged commit 88c25ad into main Feb 10, 2023
@hoxbro hoxbro deleted the add_linked_axis_bokeh3 branch February 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linked axes does not work in Bokeh 3
2 participants