Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use long_name if it is a string #5646

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Only use long_name if it is a string #5646

merged 1 commit into from
Mar 9, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Mar 8, 2023

Fixes #5615

@jlstevens I know we discussed having a warning saying that the long name should be a string, but coming back to the code after a week, I think I would rather ignore the long name if it is not a string.

@jlstevens
Copy link
Contributor

I think that is another very reasonable policy.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #5646 (08d44b7) into main (eeabab2) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5646      +/-   ##
==========================================
+ Coverage   88.25%   88.32%   +0.06%     
==========================================
  Files         302      302              
  Lines       62532    62579      +47     
==========================================
+ Hits        55189    55274      +85     
+ Misses       7343     7305      -38     
Impacted Files Coverage Δ
holoviews/core/data/xarray.py 88.86% <100.00%> (ø)
...oloviews/tests/plotting/bokeh/test_quadmeshplot.py 100.00% <0.00%> (ø)
holoviews/tests/plotting/bokeh/test_renderer.py 100.00% <0.00%> (+1.20%) ⬆️
holoviews/plotting/bokeh/util.py 64.95% <0.00%> (+1.82%) ⬆️
holoviews/plotting/bokeh/raster.py 83.33% <0.00%> (+11.71%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro
Copy link
Member Author

hoxbro commented Mar 9, 2023

Great to hear will merge this then.

@hoxbro hoxbro merged commit 03f7870 into main Mar 9, 2023
@hoxbro hoxbro deleted the long_name_str_only branch March 9, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using groupby with hvplot
3 participants