Rectangles use Bokeh quad not rect glyph #5664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5664 +/- ##
==========================================
- Coverage 88.30% 88.29% -0.01%
==========================================
Files 302 302
Lines 62539 62541 +2
==========================================
- Hits 55223 55219 -4
- Misses 7316 7322 +6
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
It also looks good to me. Is this ready to be merged? |
Yes. |
This was referenced Apr 16, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug using
hv.Rectangleson logarithmic axes when using the Bokeh WebGL backend. Related Bokeh issue is bokeh/bokeh#12734. Here is an example of the problem:The cause of the problem is that
hv.Rectangles, which are defined by min and maxxandyvalues, are implemented using bokehrectglyphs which use centre coordinates,widthandheight. The center coordinates are calculated as the means of thexandycoordinates, which makes sense for linear axes but not necessarily for logarithic. The solution is to use the Bokehquadglyph instead which is characterised by min and maxxandyso no transform of these parameters is required. Here is the output using this PR:quadglyph has been in Bokeh since at least version 1.4.0 (https://docs.bokeh.org/en/1.4.0/docs/reference/models/glyphs/quad.html?highlight=quad#bokeh.models.glyphs.Quad) in November 2019.I haven't added a new test as I don't think there are any specific webgl tests implemented.