Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest nbsite and pydata-sphinx-theme #5724

Merged
merged 5 commits into from
Jun 2, 2023
Merged

Conversation

philippjfr
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #5724 (2eb264c) into main (f4c4c12) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5724      +/-   ##
==========================================
- Coverage   88.24%   88.23%   -0.01%     
==========================================
  Files         304      304              
  Lines       62680    62680              
==========================================
- Hits        55309    55308       -1     
- Misses       7371     7372       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro
Copy link
Member

hoxbro commented May 25, 2023

When having matplotlib figures + a widget, the figure is so large you can't see the widget.

https://dev.holoviews.org/gallery/demos/matplotlib/dropdown_economic.html
image

https://holoviews.org/gallery/demos/matplotlib/dropdown_economic.html
image

@philippjfr
Copy link
Member Author

When having matplotlib figures + a widget, the figure is so large you can't see the widget.

That seems unlikely to be an nbsite issue, more likely a change in the handling of dpi in Panel or matplotlib.

[skip ci]
[skip ci]
@hoxbro hoxbro merged commit 1633084 into main Jun 2, 2023
@hoxbro hoxbro deleted the nbsite_upgrade branch June 2, 2023 10:30
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants