Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI tests #5764

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Add UI tests #5764

merged 5 commits into from
Jun 21, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jun 16, 2023

Mostly copied from Panel setup

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Merging #5764 (bcfdbac) into main (14d7d9d) will decrease coverage by 0.02%.
The diff coverage is 96.87%.

@@            Coverage Diff             @@
##             main    #5764      +/-   ##
==========================================
- Coverage   88.18%   88.16%   -0.02%     
==========================================
  Files         306      307       +1     
  Lines       62739    62761      +22     
==========================================
+ Hits        55326    55336      +10     
- Misses       7413     7425      +12     
Flag Coverage Δ
ui-tests 22.40% <90.62%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
holoviews/tests/ui/bokeh/test_layout.py 94.11% <94.11%> (ø)
holoviews/tests/conftest.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro requested a review from maximlt June 16, 2023 15:13
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good start, it's just missing some HoloViews tests :D Do you intend to add some in this PR directly?

I've left some comments. I'm also going to add something that will fall right into the nice to have category and isn't a blocker for this PR. pytest's output shows all the skipped tests which isn't super useful:
image
Not showing that doesn't seem to be super straightforward (pytest-dev/pytest#3730).

.github/workflows/test.yaml Outdated Show resolved Hide resolved
holoviews/tests/ui/bokeh/test_layout.py Show resolved Hide resolved
@hoxbro
Copy link
Member Author

hoxbro commented Jun 19, 2023

Not showing that doesn't seem to be super straightforward

Looks good but we still want to show skipped UI tests, correct?

@hoxbro hoxbro requested a review from maximlt June 20, 2023 08:16
@hoxbro hoxbro merged commit e41d63e into main Jun 21, 2023
@hoxbro hoxbro deleted the add_ui_test branch June 21, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants