-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI tests #5764
Add UI tests #5764
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5764 +/- ##
==========================================
- Coverage 88.18% 88.16% -0.02%
==========================================
Files 306 307 +1
Lines 62739 62761 +22
==========================================
+ Hits 55326 55336 +10
- Misses 7413 7425 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good start, it's just missing some HoloViews tests :D Do you intend to add some in this PR directly?
I've left some comments. I'm also going to add something that will fall right into the nice to have category and isn't a blocker for this PR. pytest's output shows all the skipped tests which isn't super useful:
Not showing that doesn't seem to be super straightforward (pytest-dev/pytest#3730).
Looks good but we still want to show skipped UI tests, correct? |
Mostly copied from Panel setup