Only merge changed instance params with rasterize #5767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
changed the title
hoxbro
changed the title
Codecov Report
@@ Coverage Diff @@
## main #5767 +/- ##
==========================================
- Coverage 88.18% 88.17% -0.01%
==========================================
Files 306 306
Lines 62739 62767 +28
==========================================
+ Hits 55326 55346 +20
- Misses 7413 7421 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippjfr
reviewed
Jun 19, 2023
philippjfr
reviewed
Jun 19, 2023
Co-authored-by: Philipp Rudiger <[email protected]>
hoxbro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #5351
Fixes #5358
rasterizehasexpand=Trueas default, whereasregridhas it asexpand=False. When applying all the parameters from the rasterize class,regridwas set to haveexpand=True.This change makes it so only non-default values are used.