Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated np.product #5787

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Remove deprecated np.product #5787

merged 1 commit into from
Jun 30, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jun 30, 2023

Removes warning seen in numpy 1.25:

❯ python -Wdefault -c "import numpy as np; np.product([1])"
sys:1: DeprecationWarning: `product` is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use `prod` instead.

Also fixes a small bug in show_versions()

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #5787 (e7e5140) into main (8df58d3) will decrease coverage by 0.03%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #5787      +/-   ##
==========================================
- Coverage   88.14%   88.12%   -0.03%     
==========================================
  Files         307      307              
  Lines       62850    62850              
==========================================
- Hits        55401    55388      -13     
- Misses       7449     7462      +13     
Flag Coverage Δ
ui-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
holoviews/element/util.py 82.21% <0.00%> (ø)
holoviews/util/_versions.py 35.29% <0.00%> (ø)
holoviews/core/data/grid.py 86.27% <100.00%> (ø)
holoviews/core/data/image.py 74.10% <100.00%> (ø)
holoviews/core/data/xarray.py 88.86% <100.00%> (ø)
holoviews/core/util.py 85.97% <100.00%> (ø)
holoviews/element/raster.py 78.97% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit 3f97338 into main Jun 30, 2023
14 checks passed
@hoxbro hoxbro deleted the product_to_prod branch June 30, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants