Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aspect handling when plot size is still unknown #5808

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jul 14, 2023

Fixes #5807
Fixes #5425

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #5808 (0e4cff1) into main (ae79eec) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #5808      +/-   ##
==========================================
- Coverage   88.15%   88.15%   -0.01%     
==========================================
  Files         307      307              
  Lines       62908    62910       +2     
==========================================
+ Hits        55459    55460       +1     
- Misses       7449     7450       +1     
Flag Coverage Δ
ui-tests 22.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
holoviews/plotting/bokeh/element.py 88.03% <50.00%> (-0.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro
Copy link
Member

hoxbro commented Jul 14, 2023

This also looks like it could fix #5425

@hoxbro hoxbro added this to the 1.17.0 milestone Jul 19, 2023
@hoxbro hoxbro merged commit b2accaf into main Jul 20, 2023
12 of 14 checks passed
@hoxbro hoxbro deleted the aspect_fix branch July 20, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants