Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix categorial regression #5850

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Fix categorial regression #5850

merged 3 commits into from
Aug 16, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 8, 2023

Fixes #5835
image

Fixes #5842
image

@hoxbro hoxbro added this to the 1.17.1 milestone Aug 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #5850 (f360ff8) into main (5ba6537) will increase coverage by 0.11%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5850      +/-   ##
==========================================
+ Coverage   88.23%   88.34%   +0.11%     
==========================================
  Files         309      310       +1     
  Lines       63915    63930      +15     
==========================================
+ Hits        56396    56480      +84     
+ Misses       7519     7450      -69     
Flag Coverage Δ
ui-tests 23.39% <30.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/plotting/bokeh/element.py 88.06% <100.00%> (+0.02%) ⬆️
holoviews/plotting/mixins.py 83.23% <100.00%> (ø)
holoviews/tests/plotting/bokeh/test_barplot.py 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro requested a review from philippjfr August 16, 2023 10:37
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love top see a test added here, otherwise this looks good.

@hoxbro hoxbro merged commit 2c0eb15 into main Aug 16, 2023
13 of 14 checks passed
@hoxbro hoxbro deleted the categorical_overlay_regression branch August 16, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants