Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty tag in Bokeh element #5851

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Handle empty tag in Bokeh element #5851

merged 2 commits into from
Aug 16, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 8, 2023

Fixes #5849

@hoxbro hoxbro added this to the 1.17.1 milestone Aug 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #5851 (5d0e7e6) into main (5ba6537) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5851   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         309      309           
  Lines       63915    63920    +5     
=======================================
+ Hits        56396    56401    +5     
  Misses       7519     7519           
Flag Coverage Δ
ui-tests 23.36% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/plotting/bokeh/element.py 88.07% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro changed the title Handle empty tag Handle empty tag in Bokeh element Aug 16, 2023
@hoxbro hoxbro merged commit dca9c01 into main Aug 16, 2023
1 check passed
@hoxbro hoxbro deleted the handle_empty_tag branch August 16, 2023 10:44
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

y_range.tags expected to be a dictionary, but it's a list
3 participants