Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to new Param 2 error messages #5865

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Aug 25, 2023

No description provided.

@hoxbro
Copy link
Member

hoxbro commented Aug 28, 2023

Is the test failing because a new release is needed?

I have added a param ==1.13 pin for the Bokeh 2 tests in #5844. So we need to add if bokeh3 to get all tests to pass.

@maximlt
Copy link
Member Author

maximlt commented Aug 28, 2023

Yep they're failing because they're relying on code that hasn't been released yet! But I don't want to force Panel to rely on the latest Param all the time so I'll adapt them to be compatible.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #5865 (79990bc) into main (e2f06d0) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##             main    #5865      +/-   ##
==========================================
- Coverage   88.36%   88.36%   -0.01%     
==========================================
  Files         310      310              
  Lines       63950    63962      +12     
==========================================
+ Hits        56512    56519       +7     
- Misses       7438     7443       +5     
Flag Coverage Δ
ui-tests 23.40% <11.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/tests/test_streams.py 98.14% <66.66%> (-0.41%) ⬇️
holoviews/tests/element/test_annotations.py 98.30% <80.00%> (-1.70%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit 04d7fa6 into main Aug 28, 2023
14 checks passed
@hoxbro hoxbro deleted the adapt_tests_param2_err branch August 28, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants