Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Bokeh UserWarning for multiple active properties in toolbar #5873

Merged
merged 6 commits into from
Sep 21, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 30, 2023

Resolves #5869

The warnings we are seeing are the tools we are actually setting in:

def _set_active_tools(self, plot):
"Activates the list of active tools"
if plot is None or self.toolbar == "disable":
return
if self.active_tools is None:
enabled_tools = set(self.default_tools + self.tools)
active_tools = {'pan', 'wheel_zoom'} & enabled_tools

We are using our merge_tools for merging tools instead of Bokeh.

No special attention has been given to Bokeh 2, as it will be removed in #5891

@hoxbro hoxbro force-pushed the ignore_multiple_competing_values branch from 6dcdb9a to 098fa32 Compare August 30, 2023 09:46
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Merging #5873 (789c6d5) into main (0b76098) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5873   +/-   ##
=======================================
  Coverage   88.28%   88.28%           
=======================================
  Files         311      311           
  Lines       64370    64372    +2     
=======================================
+ Hits        56830    56832    +2     
  Misses       7540     7540           
Flag Coverage Δ
ui-tests 23.35% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/plotting/bokeh/plot.py 91.85% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro mentioned this pull request Sep 11, 2023
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only just realized that the new merge_tools code is something I only implemented recently as part of the Bokeh 3.0 migration. The logic in there makes sense and matches our required semantics much better than what Bokeh does.

@hoxbro hoxbro merged commit 3c414fb into main Sep 21, 2023
11 checks passed
@hoxbro hoxbro deleted the ignore_multiple_competing_values branch September 21, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Bokeh toolbar UserWarning
3 participants