Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support python3-only systems #5874

Merged
merged 2 commits into from
Sep 5, 2023
Merged

support python3-only systems #5874

merged 2 commits into from
Sep 5, 2023

Conversation

MeggyCal
Copy link
Contributor

Python 2 has been dead for some time and some rolling distros (like openSUSE Tumbleweed) don't have the python binary anymore. I think that checking for the python3 binary is more inclusive and doesn't change the nature of the test.

@hoxbro
Copy link
Member

hoxbro commented Aug 31, 2023

I think this could cause problems with Windows. Can you make it an if statement? like

if shutil.which("python"):
    check_output(['python', '-c', dedent(check)])
else:
    check_output(['python3', '-c', dedent(check)])

@MeggyCal
Copy link
Contributor Author

sorry for the force-pushes :( like this?

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #5874 (4824a45) into main (e3dee54) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5874      +/-   ##
==========================================
- Coverage   88.36%   88.34%   -0.03%     
==========================================
  Files         310      310              
  Lines       63959    63956       -3     
==========================================
- Hits        56519    56503      -16     
- Misses       7440     7453      +13     
Flag Coverage Δ
ui-tests 23.40% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/tests/util/test_init.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro
Copy link
Member

hoxbro commented Aug 31, 2023

sorry for the force-pushes :( like this?

No worries. Force push is part of life. And yes.

@hoxbro
Copy link
Member

hoxbro commented Sep 5, 2023

Thank you for the PR.

Failing PRs are unrelated.

@hoxbro hoxbro merged commit 0f6ed70 into holoviz:main Sep 5, 2023
8 of 14 checks passed
@MeggyCal
Copy link
Contributor Author

MeggyCal commented Sep 5, 2023

I thank you for the review :) it's been an honor.

ahuang11 pushed a commit that referenced this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants