Use Python 3.12 for core test #5909
Conversation
| @@ -38,7 +38,6 @@ | |||
| 'bokeh', | |||
| 'pillow', | |||
| 'plotly >=4.0', | |||
| 'dash >=1.16', | |||
There was a problem hiding this comment.
Not a core-test package. Moved it down to tests.
Codecov Report
@@ Coverage Diff @@
## main #5909 +/- ##
==========================================
- Coverage 88.55% 88.55% -0.01%
==========================================
Files 313 313
Lines 65069 65077 +8
==========================================
+ Hits 57624 57629 +5
- Misses 7445 7448 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Need the libmamba solver to work on Python 3.12. |
| @@ -929,7 +929,7 @@ def isfinite(val): | |||
| if pandas_version >= Version('1.0.0'): | |||
| if finite is pd.NA: | |||
| return False | |||
| return finite & (~pd.isna(val)) | |||
| return finite & ~pd.isna(np.asarray(val)) | |||
There was a problem hiding this comment.
From this Python 3.12 warning: Bitwise inversion '~' on bool is deprecated. This returns the bitwise inversion of the underlying int object and is usually not what you expect from negating a bool. Use the 'not' operator for boolean negation or ~int(x) if you really want the bitwise inversion of the underlying int.
And val sometimes could be None or a tuple of None.
[skip ci]
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Test to see if everything runs on the latest version of Python 3.12