Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to vectorized annotators #5911

Merged
merged 10 commits into from
Oct 2, 2023
Merged

Small improvements to vectorized annotators #5911

merged 10 commits into from
Oct 2, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 28, 2023

While working on implementing vectorized annotators in Holonote, I noticed some edge cases. Which was not accounted for in the original implementation. (and some extra Pandas 2.1 warnings, e.g. next(iter(...)))

  • Add tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #5911 (6b506b7) into main (38e0b39) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5911      +/-   ##
==========================================
- Coverage   88.42%   88.38%   -0.04%     
==========================================
  Files         313      313              
  Lines       65153    65183      +30     
==========================================
+ Hits        57609    57614       +5     
- Misses       7544     7569      +25     
Flag Coverage Δ
ui-tests 23.29% <16.12%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
holoviews/plotting/bokeh/annotation.py 86.62% <100.00%> (+0.16%) ⬆️
...oviews/tests/plotting/bokeh/test_annotationplot.py 99.51% <100.00%> (-0.49%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit dfc30e7 into main Oct 2, 2023
11 checks passed
@hoxbro hoxbro deleted the update_vector branch October 2, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants