Bokeh 3.3 support #5923
Merged
Bokeh 3.3 support #5923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5923 +/- ##
==========================================
- Coverage 88.55% 88.55% -0.01%
==========================================
Files 313 313
Lines 65069 65078 +9
==========================================
+ Hits 57624 57629 +5
- Misses 7445 7449 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hoxbro
changed the title
|
Running with Bokeh 3.3, I get the following errors: |
hoxbro
changed the title
hoxbro
commented
Oct 11, 2023
| @@ -524,6 +524,8 @@ def _axis_props(self, plots, subplots, element, ranges, pos, *, dim=None, | |||
| else not util.isfinite(el) for el in [v0, v1] | |||
| ): | |||
| dim_range = range_type() | |||
| elif issubclass(range_type, FactorRange): | |||
| dim_range = range_type(name=dim.name if dim else None) | |||
There was a problem hiding this comment.
@philippjfr, do you have any fear about this change? By not setting start and end on FactorRange.
There was a problem hiding this comment.
None, whatsoever. Looks fine.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5756
With the merging bokeh/bokeh#13204, we can now support BoxEditTool again.