-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix histogram
operation on Ibis data
#5929
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5929 +/- ##
==========================================
+ Coverage 88.42% 88.45% +0.03%
==========================================
Files 313 313
Lines 65160 65209 +49
==========================================
+ Hits 57619 57683 +64
+ Misses 7541 7526 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
When this eventually gets merged after review/changes, is it possible to get a quick dev release? I'd need one to merge holoviz/hvplot#997 (unless I pin ibis there). |
LGTM 👍 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
While working on holoviz/hvplot#997 I realized that (perhaps unsurprisingly) some Ibis code paths were broken or not working as expected. I fixed some bugs related to API changes in ibis after version 5.0 and a bug in the histogram computation when
density=True
.