Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BoxAnnotation's new API Bokeh 3.3 #5935

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Support BoxAnnotation's new API Bokeh 3.3 #5935

merged 1 commit into from
Oct 12, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 12, 2023

Update to work with new API: bokeh/bokeh#13432

@hoxbro hoxbro added this to the 1.18.0 milestone Oct 12, 2023
@hoxbro hoxbro enabled auto-merge (squash) October 12, 2023 16:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #5935 (622f37f) into main (70477d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5935   +/-   ##
=======================================
  Coverage   88.57%   88.58%           
=======================================
  Files         313      313           
  Lines       65086    65100   +14     
=======================================
+ Hits        57653    57668   +15     
+ Misses       7433     7432    -1     
Flag Coverage Δ
ui-tests 23.29% <12.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
holoviews/plotting/bokeh/annotation.py 86.66% <100.00%> (+0.04%) ⬆️
...oviews/tests/plotting/bokeh/test_annotationplot.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit 53f816e into main Oct 12, 2023
11 checks passed
@hoxbro hoxbro deleted the bokeh33_2 branch October 12, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants