Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display globals to notebook_extension #5947

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Add display globals to notebook_extension #5947

merged 2 commits into from
Oct 18, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 18, 2023

Adds feature implemented in holoviz/panel#5657 and holoviz/panel#5661

Should improve the experience seen in #5866

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #5947 (75e1ca5) into main (c7aa7d0) will decrease coverage by 0.01%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main    #5947      +/-   ##
==========================================
- Coverage   88.58%   88.58%   -0.01%     
==========================================
  Files         315      315              
  Lines       65504    65514      +10     
==========================================
+ Hits        58026    58034       +8     
- Misses       7478     7480       +2     
Flag Coverage Δ
ui-tests 23.14% <13.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
holoviews/ipython/__init__.py 75.92% <100.00%> (+0.30%) ⬆️
holoviews/operation/resample.py 89.25% <81.81%> (-1.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro
Copy link
Member Author

hoxbro commented Oct 18, 2023

The browser_info is available inside the notebook and when serving inside a template. It is not available when working in a "pure" panel serve app-

@hoxbro hoxbro enabled auto-merge (squash) October 18, 2023 12:38
@hoxbro hoxbro merged commit eb923af into main Oct 18, 2023
10 checks passed
@hoxbro hoxbro deleted the display_globals branch October 18, 2023 12:46
hoxbro added a commit that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants