Updates to work with numpy 2.0 #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
commented
Nov 6, 2023
|
Thanks Simon! 🙏 Is HoloViews running CI with NumPy 2? |
|
I just tried enabling it, but I could not get it to solve because of matplotlib. Though looking at numpy/numpy#26191 it seems like it should be supported in version 3.8.4
Getting this error: The following packages are incompatible
├─ matplotlib-base is installable with the potential options
│ ├─ matplotlib-base [2.1.2|2.2.4|...|3.2.2] would require
│ │ └─ numpy >=1.14.6,<2.0a0 , which can be installed;
│ ├─ matplotlib-base 2.2.3 would require
│ │ └─ numpy >=1.9.3,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [2.2.5|3.3.0|3.3.1|3.3.2|3.3.3] would require
│ │ └─ numpy >=1.16.5,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [2.2.5|3.3.2] would require
│ │ └─ numpy >=1.19.2,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [2.2.5|3.3.2|3.3.3] would require
│ │ └─ numpy >=1.19.4,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.0.2|3.0.3|3.1.0] would require
│ │ └─ numpy >=1.11.3,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.2.2|3.3.0|...|3.5.1] would require
│ │ └─ numpy >=1.18.5,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.3.0|3.3.1|3.3.2] would require
│ │ └─ numpy >=1.15.4,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.3.3|3.3.4] would require
│ │ └─ numpy >=1.16.6,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.3.3|3.3.4|...|3.5.3] would require
│ │ └─ numpy >=1.19.5,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.4.1|3.4.2] would require
│ │ └─ numpy >=1.17.5,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.4.3|3.5.0|3.5.1] would require
│ │ └─ numpy >=1.21.4,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.5.2|3.5.3|...|3.7.2] would require
│ │ └─ numpy >=1.21.6,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.6.0|3.6.1|...|3.7.1] would require
│ │ └─ numpy >=1.20.3,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.6.1|3.6.2] would require
│ │ └─ numpy >=1.23.4,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.6.3|3.7.0|...|3.8.4] would require
│ │ └─ numpy >=1.23.5,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.7.3|3.8.0|...|3.8.4] would require
│ │ └─ numpy >=1.22.4,<2.0a0 , which can be installed;
│ ├─ matplotlib-base [3.8.0|3.8.1|3.8.2] would require
│ │ └─ numpy >=1.26.0,<2.0a0 , which can be installed;
│ └─ matplotlib-base [3.8.3|3.8.4] would require
│ └─ numpy >=1.26.4,<2.0a0 , which can be installed;
└─ numpy 2.0.0rc1** is not installable because it conflicts with any installable versions previously reported. |
|
Thanks Simon! 🙏 On the conda-forge side, we need to start a NumPy 2 migration to build other packages with NumPy 2. There is some work happening in that direction in PR ( conda-forge/conda-forge-pinning-feedstock#5790 ). However it is not yet ready to ship. Hopefully soon |
|
Since we last talked, the NumPy 2 migration in conda-forge has begun Matplotlib has also been migrated. So installing it now does work (please see "Details" below) Are there other dependencies we need here? |
|
I have opened #6238, which tests for Numpy 2.0. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found with the latest release of ruff and this command
ruff check . --preview --select=NPY201 --fix