Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hist on overlay #5995

Merged
merged 17 commits into from
Nov 23, 2023
Merged

Fix hist on overlay #5995

merged 17 commits into from
Nov 23, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 22, 2023

I noticed while looking at docs failures: https://holoviews.org/Homepage.html

I don't think we use this file anymore, so I could delete it. Deleted it.

I need to use a plotting backend or else I will get ValueError: No plotting extension is currently loaded. This is built on top of the changes made in #5954

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e5eacf) 88.58% compared to head (4ac72cc) 88.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5995      +/-   ##
==========================================
+ Coverage   88.58%   88.60%   +0.02%     
==========================================
  Files         315      315              
  Lines       65583    65592       +9     
==========================================
+ Hits        58095    58121      +26     
+ Misses       7488     7471      -17     
Flag Coverage Δ
ui-tests 23.27% <45.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from fix_unsort to main November 22, 2023 08:52
@hoxbro hoxbro enabled auto-merge (squash) November 22, 2023 09:59
@hoxbro hoxbro disabled auto-merge November 22, 2023 10:24
@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label Nov 23, 2023
@hoxbro hoxbro enabled auto-merge (squash) November 23, 2023 08:14
@hoxbro hoxbro merged commit 2514f97 into main Nov 23, 2023
11 of 12 checks passed
@hoxbro hoxbro deleted the histogram_image_overlay branch November 23, 2023 11:19
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants