Add extra check to detect if we are in jupyterlite #6007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6007 +/- ##
=======================================
Coverage 88.61% 88.61%
=======================================
Files 315 315
Lines 65593 65593
=======================================
Hits 58122 58122
Misses 7471 7471
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Doesn't that automatically get inherited from Panel? |
philippjfr
reviewed
Dec 5, 2023
hoxbro
force-pushed
the
extra_check_jupyterlite
branch
from
201f463
to
26ae62c
Compare
philippjfr
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_JUPYTERLABis no longer there when running jupyterlite, so found another way to detect it.https://jupyter.org/try-jupyter/lab/