Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ImageStack in dynspread #6024

Merged
merged 3 commits into from
May 17, 2024
Merged

Support ImageStack in dynspread #6024

merged 3 commits into from
May 17, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 11, 2023

Resolves #5993

screenrecord-2023-12-11_11.56.54.mp4

@hoxbro hoxbro added the type: enhancement Minor feature or improvement to an existing feature label Dec 11, 2023
@hoxbro hoxbro marked this pull request as draft December 11, 2023 12:57
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (802edf7) to head (6914e3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6024       +/-   ##
===========================================
+ Coverage   17.43%   88.39%   +70.95%     
===========================================
  Files         323      323               
  Lines       67588    67621       +33     
===========================================
+ Hits        11784    59771    +47987     
+ Misses      55804     7850    -47954     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlstevens
Copy link
Contributor

Glad to see that the current codepath in datashader seems to work!

Two things to note:

  1. As an extra validation, I would like to see dynspread using datashade next to dynspread using ImageStack - if everything is working correctly they should basically look the same.
  2. I think more work is needed to support imagestack fully in the way we are imagining. For instance, supporting the spreading of layers that are not colormixed and included to added hover information. Such layers may not be numeric (e.g. text!) but should also be spread. The way I would imagine it is as if you are spreading a i64 image (an index per unique value) and then using those values as indices back to the data.

While the first thing would be good to check before merging this PR, the second thing is a fair bit more work and can be made into a feature request and addressed in a future PR.

@droumis
Copy link
Member

droumis commented Mar 7, 2024

@philippjfr: "To efficiently spread multiple layers, we may have to do this in Datashader"

@philippjfr philippjfr added this to the 1.19.0 milestone May 17, 2024
@hoxbro
Copy link
Member Author

hoxbro commented May 17, 2024

I will add a small test and then merge this. We can always improve functionality later.

@hoxbro hoxbro marked this pull request as ready for review May 17, 2024 12:14
@hoxbro hoxbro enabled auto-merge (squash) May 17, 2024 12:14
@hoxbro hoxbro merged commit 850c521 into main May 17, 2024
13 checks passed
@hoxbro hoxbro deleted the support_dynspread branch May 17, 2024 12:46
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new ImageStack element in dynspread operation
5 participants