Add 'norm' in init_artists in holoviews/plotting/mpl/raster.py, #6029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added handling of 'norm' kwarg to init_artists in order to pass norm when plotting with matplotlib backend.
|
Thank you. I can see there is an extra space in the indentation. Can you fix it here (and also if it is there in element.py)? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6029 +/- ##
=======================================
Coverage 88.59% 88.60%
=======================================
Files 315 315
Lines 65606 65613 +7
=======================================
+ Hits 58123 58135 +12
+ Misses 7483 7478 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fixed indentation
fixed indentation
|
Indentation fixed. |
|
Thank you. I will let it merge if the CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling of 'norm' kwarg to init_artists in the same way is already present in /holoviews/plotting/mpl/element.py, in order to pass norm when plotting a quadmesh with matplotlib backend. This allows to pass a custom norm and colormap to be able to plot a colobar with discrete, uneven intervals correctly. Related to #5966