Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add true if inputs.cache is not set #6050

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Add true if inputs.cache is not set #6050

merged 1 commit into from
Dec 22, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 22, 2023

Follow up to #6043

Actions triggered by a workflow dispatch will have github.event.inputs.cache as empty, meaning that cache not be set in the holoviz-dev/holoviz_tasks/install action and defaulting to false.

@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label Dec 22, 2023
@hoxbro hoxbro enabled auto-merge (squash) December 22, 2023 16:24
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f46e512) 88.65% compared to head (122c7c5) 88.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6050   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files         314      314           
  Lines       65688    65688           
=======================================
  Hits        58234    58234           
  Misses       7454     7454           
Flag Coverage Δ
ui-tests 23.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro merged commit 62b7f1e into main Dec 22, 2023
12 of 13 checks passed
@hoxbro hoxbro deleted the cache_true_by_default branch December 22, 2023 17:39
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants