Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable always on warnings #6077

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Disable always on warnings #6077

merged 2 commits into from
Jan 19, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 19, 2024

Because of the use of find_stack_level we should not always emit the DeprecationWarning.

This means that only the module or user calling the deprecated function will receive the warning.

@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label Jan 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbab2b7) 88.65% compared to head (0a97ff1) 88.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6077      +/-   ##
==========================================
- Coverage   88.65%   88.65%   -0.01%     
==========================================
  Files         314      314              
  Lines       65817    65815       -2     
==========================================
- Hits        58348    58346       -2     
  Misses       7469     7469              
Flag Coverage Δ
ui-tests 23.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro merged commit c0e6064 into main Jan 19, 2024
12 checks passed
@hoxbro hoxbro deleted the disable-always-filter branch January 19, 2024 14:12
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants