Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update show_versions to use package name #6081

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Update show_versions to use package name #6081

merged 1 commit into from
Jan 24, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 24, 2024

Changes in #6072 to no use importlib.metadata.version meant that we should use the package name and not the import name.

I also added a tsdownsample to the list.

@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label Jan 24, 2024
@hoxbro hoxbro enabled auto-merge (squash) January 24, 2024 11:36
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6dc23ae) 88.65% compared to head (6c1c45d) 88.65%.

Files Patch % Lines
holoviews/util/_versions.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6081      +/-   ##
==========================================
- Coverage   88.65%   88.65%   -0.01%     
==========================================
  Files         314      314              
  Lines       65839    65841       +2     
==========================================
+ Hits        58370    58371       +1     
- Misses       7469     7470       +1     
Flag Coverage Δ
ui-tests 23.67% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro disabled auto-merge January 24, 2024 12:12
@hoxbro hoxbro merged commit 48aa328 into main Jan 24, 2024
@hoxbro hoxbro deleted the update_show_versions branch January 24, 2024 12:20
hoxbro added a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants