-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test for Bokeh 3.4 #6130
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6130 +/- ##
===========================================
- Coverage 88.56% 23.79% -64.77%
===========================================
Files 316 316
Lines 66010 66013 +3
===========================================
- Hits 58460 15710 -42750
- Misses 7550 50303 +42753
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It won't solve correctly with the dev version of panel + bokeh for unit test cases. This will likely solve itself with the official release of both. I have run the examples and unit test locally and got no error with this PR. The reason for the difference in the lasso select UI test in Bokeh 3.4 is unclear to me. It could be related to the floating UI pr. I would like to merge this PR, as the UI test is failing. |
Now, we also test the unit test with the latest panel and Bokeh dev release. Will add the check latest release in a follow up PR, when the next version of Panels dev release have been made. |
@mattpap, do you know what causes the change in lasso_select between 3.3 and 3.4? And if the change is expected and therefore okay? |
Gesture and UI event handling was redesigned, among other things. It seems OK and aligned with the difference between old and new approaches. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Noticed here:
https://github.com/holoviz/holoviews/actions/runs/8020821711/job/21924068272