Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test for Bokeh 3.4 #6130

Merged
merged 16 commits into from
Feb 27, 2024
Merged

Update test for Bokeh 3.4 #6130

merged 16 commits into from
Feb 27, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Feb 26, 2024

@hoxbro hoxbro added the type: compatibility Compability with upstream packages label Feb 26, 2024
@hoxbro hoxbro changed the title Update test to use Bokeh 3.4 Update test for Bokeh 3.4 Feb 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 23.79%. Comparing base (a66eb55) to head (e98bef2).

Files Patch % Lines
...oviews/tests/plotting/bokeh/test_annotationplot.py 75.00% 1 Missing ⚠️
holoviews/tests/ui/bokeh/test_callback.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6130       +/-   ##
===========================================
- Coverage   88.56%   23.79%   -64.77%     
===========================================
  Files         316      316               
  Lines       66010    66013        +3     
===========================================
- Hits        58460    15710    -42750     
- Misses       7550    50303    +42753     
Flag Coverage Δ
ui-tests 23.79% <85.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro
Copy link
Member Author

hoxbro commented Feb 26, 2024

It won't solve correctly with the dev version of panel + bokeh for unit test cases. This will likely solve itself with the official release of both.

I have run the examples and unit test locally and got no error with this PR.

The reason for the difference in the lasso select UI test in Bokeh 3.4 is unclear to me. It could be related to the floating UI pr.

I would like to merge this PR, as the UI test is failing.

@hoxbro hoxbro marked this pull request as draft February 27, 2024 13:50
@hoxbro hoxbro marked this pull request as ready for review February 27, 2024 16:21
@hoxbro
Copy link
Member Author

hoxbro commented Feb 27, 2024

Now, we also test the unit test with the latest panel and Bokeh dev release.

Will add the check latest release in a follow up PR, when the next version of Panels dev release have been made.

@hoxbro
Copy link
Member Author

hoxbro commented Feb 27, 2024

@mattpap, do you know what causes the change in lasso_select between 3.3 and 3.4? And if the change is expected and therefore okay?

@mattpap
Copy link

mattpap commented Feb 27, 2024

do you know what causes the change in lasso_select between 3.3 and 3.4? And if the change is expected and therefore okay?

Gesture and UI event handling was redesigned, among other things. It seems OK and aligned with the difference between old and new approaches.

@hoxbro hoxbro merged commit 9e5f904 into main Feb 27, 2024
12 checks passed
@hoxbro hoxbro deleted the bokeh34 branch February 27, 2024 18:08
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: compatibility Compability with upstream packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants