Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dask setting to disable query-planning for now #6149

Merged
merged 8 commits into from
Mar 14, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ jobs:
run: |
conda activate test-environment
conda uninstall panel bokeh --force --offline -y || true
pip install bokeh panel --pre
pip install bokeh 'panel==1.4.0b2' --pre
hoxbro marked this conversation as resolved.
Show resolved Hide resolved
echo "Installing dev releases of Panel and Bokeh" >> $GITHUB_STEP_SUMMARY
- name: Check packages latest version
if: needs.setup.outputs.code_change == 'true'
Expand Down
5 changes: 4 additions & 1 deletion holoviews/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,14 @@ def pytest_collection_modifyitems(config, items):


with contextlib.suppress(Exception):
# From Dask 2023.7,1 they now automatic convert strings
# From Dask 2023.7.1 they now automatically convert strings
# https://docs.dask.org/en/stable/changelog.html#v2023-7-1
# From Dask 2024.3.0 they now use `dask_expr` by default
# https://github.com/dask/dask/issues/10995
import dask

dask.config.set({"dataframe.convert-string": False})
dask.config.set({"dataframe.query-planning": False})


@pytest.fixture
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"param >=1.12.0,<3.0",
"numpy >=1.0",
"pyviz_comms >=2.1",
"panel >=1.0",
"panel ==1.4.0b2",
hoxbro marked this conversation as resolved.
Show resolved Hide resolved
"colorcet",
"packaging",
"pandas >=0.20.0",
Expand Down
Loading