Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ruff and remove Bokeh rc workarounds #6152

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Bump ruff and remove Bokeh rc workarounds #6152

merged 4 commits into from
Mar 15, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Mar 15, 2024

Code changes are related to Ruff now flagging multiple line f-strings.

@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label Mar 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 23.79%. Comparing base (075ae6e) to head (29d6d2b).
Report is 1 commits behind head on main.

Files Patch % Lines
holoviews/element/raster.py 0.00% 2 Missing ⚠️
holoviews/plotting/plotly/element.py 0.00% 2 Missing ⚠️
holoviews/tests/utils.py 0.00% 2 Missing ⚠️
holoviews/util/__init__.py 0.00% 2 Missing ⚠️
holoviews/core/dimension.py 0.00% 1 Missing ⚠️
holoviews/core/io.py 0.00% 1 Missing ⚠️
holoviews/ipython/archive.py 0.00% 1 Missing ⚠️
holoviews/operation/datashader.py 0.00% 1 Missing ⚠️
holoviews/plotting/bokeh/element.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6152       +/-   ##
===========================================
- Coverage   88.69%   23.79%   -64.90%     
===========================================
  Files         316      316               
  Lines       66017    66014        -3     
===========================================
- Hits        58554    15711    -42843     
- Misses       7463    50303    +42840     
Flag Coverage Δ
ui-tests 23.79% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro
Copy link
Member Author

hoxbro commented Mar 15, 2024

It still needs a new dev release of Panel to pass the test, so I will merge this for now.

Ref: #6149

@hoxbro hoxbro merged commit baa69b1 into main Mar 15, 2024
4 of 11 checks passed
@hoxbro hoxbro deleted the maint branch March 15, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants