Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve autocompletion for lazy module #6174

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Apr 5, 2024

__dir__ is for IPython/Jupyter, and type checking is for LSP like Pylance.

(I am also using this PR for some unrelated clean up)

@hoxbro hoxbro enabled auto-merge (squash) April 5, 2024 07:26
@hoxbro hoxbro added type: maintenance infrastructure and maintenance of CI type: enhancement Minor feature or improvement to an existing feature and removed type: maintenance infrastructure and maintenance of CI labels Apr 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.53%. Comparing base (fef3219) to head (2afcc02).
Report is 2 commits behind head on main.

Files Patch % Lines
holoviews/__init__.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6174      +/-   ##
==========================================
- Coverage   88.68%   88.53%   -0.15%     
==========================================
  Files         316      316              
  Lines       66073    66076       +3     
==========================================
- Hits        58597    58502      -95     
- Misses       7476     7574      +98     
Flag Coverage Δ
ui-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro merged commit bf4592e into main Apr 6, 2024
11 checks passed
@hoxbro hoxbro deleted the improve_lazy_autocomplete branch April 6, 2024 06:33
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants