Ensure that the downsample algorithm m4 n_out is always a multiple of 4 #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
reviewed
Apr 18, 2024
| @@ -188,6 +188,7 @@ def _m4(x, y, n_out, **kwargs): | |||
| 'The m4 downsampling algorithm requires the tsdownsampler ' | |||
| 'library to be installed.' | |||
| ) from None | |||
| n_out = n_out - (n_out % 4) # n_out must be a multiple of 4 | |||
There was a problem hiding this comment.
Wouldn't it be safer to increase the number of samples, to handle degenerate cases where otherwise there might be only a tiny number of samples? Please ignore if I'm misunderstanding this.
There was a problem hiding this comment.
We never downsample something where the number of points is smaller than the width of the plot, so there will never be a tiny number of samples.
The case reported in the issue n_out is around 210 to 217 samples, so adding or subtracting 3 at most for it seemed negligible.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6192