Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new conda package format #6216

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Use the new conda package format #6216

merged 1 commit into from
Jun 6, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 4, 2024

It seems logical to use the new format for conda packaging; it should be faster, which can't hurt.

https://conda.io/projects/conda-build/en/latest/resources/package-spec.html

@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label May 4, 2024
@hoxbro hoxbro changed the title Try the new conda package format Use the new conda package format Jun 3, 2024
@hoxbro hoxbro added this to the 1.19.0 milestone Jun 3, 2024
@hoxbro hoxbro requested a review from maximlt June 5, 2024 08:58
@philippjfr philippjfr merged commit c7e9f9e into main Jun 6, 2024
19 of 20 checks passed
@philippjfr philippjfr deleted the conda_build_new_format branch June 6, 2024 12:21
@maximlt
Copy link
Member

maximlt commented Jun 7, 2024

Didn't get a chance to post my review but this was briefly discussed live yesterday. It's fine it got merged but I wouldn't push for migrating all the HoloViz pyviz packages to this format until .tar.bz2 is deprecated, as inspecting a .conda file is cumbersome (un-archive the whole thing and then un-archive the two .tar.zst files it contains).

@hoxbro
Copy link
Member Author

hoxbro commented Jun 7, 2024

It isn't that cumbersome. It only takes a couple of seconds to do the extra step. And (good) archive managers can look inside nested archives.

But I won't push it for other packages. I will let that be up to the lead maintainers of the respective project.

@maximlt
Copy link
Member

maximlt commented Jun 7, 2024

It isn't that cumbersome. It only takes a couple of seconds to do the extra step. And (good) archive managers can look inside nested archives.

For you maybe. I tried on Windows and the default archive manager wouldn't work. Tried on Mac too and after extracting the first archive, somehow extracting .tar.zst created a .tar.zst.cpgz.

@hoxbro
Copy link
Member Author

hoxbro commented Jun 7, 2024

That's what I meant by good.

I don't think any people will unpack the conda package by themselves, and if they do, they will know how to do it.

@philippjfr
Copy link
Member

Inspecting a package seems like a pretty niche use case, reserved primarily to developers, i.e. us, so I'd also argue it's not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants