Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum version of param to 2.0 and add stream transform #6230

Merged
merged 6 commits into from
May 14, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 14, 2024

  • Bumps minimum version of param to 2.0
  • Remove Panel Widget and replace with param.parameterized.resolve_ref did not work, because resolve_ref returns a list no matter what, and I only want the value parameter.
  • Add Pipe and therefore Streams to reactive transform and therefore fixes Buffer does not work as dict argument to Dynamic Map #6229

@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.19%. Comparing base (d338915) to head (b76ee02).

Files Patch % Lines
holoviews/streams.py 85.71% 1 Missing ⚠️
holoviews/util/__init__.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6230   +/-   ##
=======================================
  Coverage   88.18%   88.19%           
=======================================
  Files         321      321           
  Lines       67360    67344   -16     
=======================================
- Hits        59402    59391   -11     
+ Misses       7958     7953    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro added type: enhancement Minor feature or improvement to an existing feature and removed type: bug Something isn't correct or isn't working labels May 14, 2024
@hoxbro hoxbro requested a review from philippjfr May 14, 2024 09:35
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hoxbro hoxbro merged commit 6f042b3 into main May 14, 2024
15 checks passed
@hoxbro hoxbro deleted the update_param branch May 14, 2024 11:42
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buffer does not work as dict argument to Dynamic Map
2 participants