Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document subcoordinate_group_ranges by extending the EEG Viewer demo #6243

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented May 21, 2024

This makes the example a bit more complicated as it adds another data dimension but I think overall it is still fine, and from what I understand having multiple groups when dealing with EEG data is not unexpected.

image

@maximlt maximlt added the type: docs Related to the documentation and examples label May 21, 2024
@droumis droumis self-requested a review May 28, 2024 14:51
@droumis
Copy link
Member

droumis commented Jun 3, 2024

Refactored, adding different data type groups, plotting from wide pandas DFs, coloring, rasterization of the minimap, and other minor edits.

image

@droumis
Copy link
Member

droumis commented Jun 3, 2024

@maximlt please check my changes

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.47%. Comparing base (2ba3d78) to head (3e8629d).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6243      +/-   ##
==========================================
+ Coverage   88.39%   88.47%   +0.08%     
==========================================
  Files         323      323              
  Lines       67620    67639      +19     
==========================================
+ Hits        59770    59846      +76     
+ Misses       7850     7793      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximlt
Copy link
Member Author

maximlt commented Jun 4, 2024

@droumis very nice updates thanks! I simply added a redirect link in 3e8629d since the EEG Viewer Bokeh demo was already released (I'm running a doc build on the CI now to check if it builds correctly). I'll merge when everything passes.

@maximlt maximlt merged commit 6e501e9 into main Jun 4, 2024
17 checks passed
@maximlt maximlt deleted the document_subcoordy_extras branch June 4, 2024 14:39
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: docs Related to the documentation and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants