-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix vectorfield hover #6258
fix vectorfield hover #6258
Conversation
I'm not a fan of this solution. The main reason is you increase the data by a factor of 4. If we choose to go this way, we should at least limit this only to be done when we have an actual hover tool. By the looks of it, you send all the data to the front end no matter what. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6258 +/- ##
==========================================
+ Coverage 88.39% 88.51% +0.12%
==========================================
Files 323 323
Lines 67620 67659 +39
==========================================
+ Hits 59770 59887 +117
+ Misses 7850 7772 -78 ☔ View full report in Codecov by Sentry. |
Maybe add two tests that check that hover information is sent to the front end if hover is enabled and one that checks it is not if hover is not enabled. |
Co-authored-by: Simon Høxbro Hansen <[email protected]>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Not sure there's a better solution, but I think it's better than no solution because hover is useful:
Closes #3785