Disable batching when subcoordinate_y is enabled #6272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6272 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 323 323
Lines 67934 67945 +11
=======================================
+ Hits 60146 60157 +11
Misses 7788 7788 ☔ View full report in Codecov by Sentry. |
philippjfr
commented
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batching kicks in when you are plotting more than
legend_limitelements inside anNdOverlay. However for asubcoordinate_yplot batching is not and cannot be supported since each element has to be plotted using a different renderer instance. Therefore we check ifsubcoordinate_yis enabled before enabling batching.