-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop z dimension from ImageStack DataArray before shading #6378
Conversation
a7368b6
to
d0e088c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6378 +/- ##
==========================================
- Coverage 88.50% 88.49% -0.01%
==========================================
Files 323 323
Lines 68281 68304 +23
==========================================
+ Hits 60429 60448 +19
- Misses 7852 7856 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you haven't already maybe also run the hvplot test suite (locally) to verify that this change does not break anything because of the changes in XarrayInterface
.
Co-authored-by: Simon Høxbro Hansen <[email protected]>
Done, it's passing. |
When performing categorical rasterization with only one category the
XArrayInterface
would convert the 3DDataArray
into a Dataset. When this 3D Dataset was then shaded we would convert the singular DataArray variable into a z-dimension, which meant we'd have two categorical variables (with the same value) and datashader would error out because it expects a 2D or 3D array.Here we do a number of things:
XArrayInterface
to hold a DataArray with a singular value dimension